Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser] fix code gen overflow - reapply #110606

Merged
merged 2 commits into from
Dec 12, 2024
Merged

[browser] fix code gen overflow - reapply #110606

merged 2 commits into from
Dec 12, 2024

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 11, 2024 •
edited
Loading

Reapply "[browser] fix code gen overflow (#110539)" (#110599)

Fixes #84996

@pavelsavara pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm labels Dec 11, 2024
@pavelsavara pavelsavara added this to the 10.0.0 milestone Dec 11, 2024
@pavelsavara pavelsavara self-assigned this Dec 11, 2024
@pavelsavara pavelsavara mentioned this pull request Dec 11, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Dec 11, 2024
Open
3 tasks
@pavelsavara
Copy link
Member Author

image

@pavelsavara pavelsavara marked this pull request as ready for review December 11, 2024 17:09
@pavelsavara pavelsavara requested a review from lewing as a code owner December 11, 2024 17:09
@pavelsavara pavelsavara merged commit bf40019 into dotnet:main Dec 12, 2024
91 checks passed
@pavelsavara pavelsavara deleted the js_gen_fix_hash_again branch December 12, 2024 13:14
hez2010 pushed a commit to hez2010/runtime that referenced this pull request Dec 14, 2024
@pavelsavara @hez2010
[browser] fix code gen overflow - reapply (dotnet#110606)
0c0281e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@lewing lewing Awaiting requested review from lewing lewing is a code owner

Assignees

@pavelsavara pavelsavara

Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript os-browser Browser variant of arch-wasm
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

JSSignatureContext.cs may include incorrect use of Math.Abs
2 participants
@pavelsavara @akoeplinger